-
kcmackeen authored
Remove v1beta1 VerticaDB API, as well as webhook to convert from v1beta1 to v1. This required several small changes throughout the code to use v1 version of functions instead of v1beta1. Unit tests are now passing using just v1 VDB. Also, I had to make **MANY** changes to the e2e tests so that all tests only use v1 VDB. This also required changing the syntax for many setup-vdb.yaml files, for example to use: ``` annotations: vertica.com/k-safety: "0" ``` Instead of: ` kSafety: "0" ` Some important notes from this PR: 1) We can no longer upgrade (directly or indirectly) from 1.X versions to 25.3+. This is because v1 was introduced in 2.0. As of 2.0, any VDB created in v1beta1 will be auto-converted to v1. However, any VDB created before this version and then upgraded will never follow the conversion logic, and it will remain as v1beta1. With v1beta1 removed in 25.3, this VDB will no longer be supported. It must be re-created using v1 API. 2) We cannot upgrade the verticadb CRD from <25.3 to 25.3+ using "kubectl apply". This is because the <25.3 CRD will contain webhook conversion logic, and "kubectl apply" cannot overwrite this. We must use "kubectl patch"; for example, use the below command to clear conversion before using "kubectl apply": kubectl patch crd verticadbs.vertica.com --type merge -p '{\"spec\":{\"conversion\":null}}' 3) In v1beta1, if encryptSpreadComm was not specified, it would be saved as "disabled"; in v1, it will now be "vertica" 4) httpServerMode was deprecated and was only included in v1beta1; it has now been removed --------- Co-authored-by:
roypaulin <rnguetsopken@opentext.com>
kcmackeen authoredRemove v1beta1 VerticaDB API, as well as webhook to convert from v1beta1 to v1. This required several small changes throughout the code to use v1 version of functions instead of v1beta1. Unit tests are now passing using just v1 VDB. Also, I had to make **MANY** changes to the e2e tests so that all tests only use v1 VDB. This also required changing the syntax for many setup-vdb.yaml files, for example to use: ``` annotations: vertica.com/k-safety: "0" ``` Instead of: ` kSafety: "0" ` Some important notes from this PR: 1) We can no longer upgrade (directly or indirectly) from 1.X versions to 25.3+. This is because v1 was introduced in 2.0. As of 2.0, any VDB created in v1beta1 will be auto-converted to v1. However, any VDB created before this version and then upgraded will never follow the conversion logic, and it will remain as v1beta1. With v1beta1 removed in 25.3, this VDB will no longer be supported. It must be re-created using v1 API. 2) We cannot upgrade the verticadb CRD from <25.3 to 25.3+ using "kubectl apply". This is because the <25.3 CRD will contain webhook conversion logic, and "kubectl apply" cannot overwrite this. We must use "kubectl patch"; for example, use the below command to clear conversion before using "kubectl apply": kubectl patch crd verticadbs.vertica.com --type merge -p '{\"spec\":{\"conversion\":null}}' 3) In v1beta1, if encryptSpreadComm was not specified, it would be saved as "disabled"; in v1, it will now be "vertica" 4) httpServerMode was deprecated and was only included in v1beta1; it has now been removed --------- Co-authored-by:
roypaulin <rnguetsopken@opentext.com>
Loading